# PR #154 — Unified Things page

Branch: `claude/unified-things-page-796e34`

## Follow-up: search, browse controls, and auto-icons

The `/things` visual follow-up fixes three related rough edges:

- Pin absolute `Rainbow` overlays to `top: 0; left: 0` so the animated search
  border follows its padded wrapper on every side instead of inheriting a
  two-pixel static-position offset.
- Give View / Show / Arrange / Kind pills real outline-button padding and group
  each labelled control family so responsive wrapping never orphans a label.
- Replace the generic fallback-heavy icon switch with an ordered, deterministic
  registry for Thing kinds and file families. Screenshot-like names take
  precedence over image MIME data (`🖼️`), photos use `🏞️`, recognised file
  families receive distinct icons, and unknown files use `💾`.
- Make the browse-control pills more compact by default and expose their
  padding as a theme token with Small / Medium / Large presets plus a safe
  custom CSS-padding shorthand. The control is available in Theme Studio and
  both Appearance quick-settings surfaces, and saved themes carry the choice.

## Validation

- `corepack pnpm --dir remix exec node --import tsx --test app/components/Things/thingIcon.test.ts` — 5/5 passed.
- `corepack pnpm --dir remix exec node --import tsx --test app/theme/tokens.test.ts` — badge padding preset/custom sanitisation coverage.
- Targeted Remix ESLint — 0 errors; 8 pre-existing warnings in `Rainbow.tsx`
  and `ThingsPage.tsx`.
- `corepack pnpm --dir remix run build:client` — passed.
- Local `/things` desktop and mobile browser QA covered search input, every
  control family, sort/group menus, responsive wrapping, top-to-bottom scroll,
  and horizontal overflow. The search wrapper and rainbow overlay had matching
  bounds; every pill measured 12 px inline padding; app-origin console logs
  were empty.

## Follow-up: recoverable first-session Things space

- A fresh `/things` landing now creates a rate-limited temporary user through
  the canonical user-Thing, subscription, session, JWT, and account-roster
  paths before the route paints. The Things UI therefore has a real owner and
  all ordinary ACL/quota rules apply; there is no anonymous write bypass.
- The bootstrap is idempotent for an existing session, marks the public user
  as temporary, bounds it to a 64 MiB allowance, and keeps login/register
  reachable so another account can be added while the browser roster retains
  the temporary space.
- Temporary identities are labelled as browser-saved in the account switcher
  and do not show a misleading email-verification warning for their internal
  placeholder address.

### Validation

- `corepack pnpm --dir remix run test:temporary-user` — 3/3 passed, covering
  generated-account constraints, exact `/things` routing, proxy-aware
  same-origin acceptance, and foreign-origin rejection.
- Targeted Remix ESLint passed with 0 warnings/errors; the complete Vercel
  production build and static-shell verification passed.
- Direct runtime calls returned `201 reused:false` for the first bootstrap and
  `200 reused:true` with the same user id for the second, with `temporary:true`
  and the 64 MiB allowance in the public projection.
- A clean in-app browser session landed on `/things` as “Temporary space”,
  created a private folder through the real Things UI, retained it after
  reload, reached both `/login` and `/register` without redirecting, then
  deleted the QA folder. Desktop 1280×800 and mobile 390×844 top-to-bottom
  checks had no horizontal overflow, clipped controls, or console errors.
- The full typecheck ratchet remains warning-only at 152 diagnostics versus its
  stale 143 baseline; none of the reported diagnostics are in this change.

## Follow-up: anonymous session presentation

- Temporary users remain real, recoverable session owners underneath, but the
  global navigation presents the standard logged-out `Login` action instead
  of naming the temporary space.
- New and existing temporary profiles project as `Anonymous`. Account,
  profile, people, feed, messenger, sharing, schema, and app-data identity
  renderers use `Login to claim` instead of exposing the generated `guest-*`
  username or placeholder email.
- The OAuth authorisation surface treats a temporary session as signed out, so
  a third-party app cannot be authorised under an internal guest identity.

### Validation

- `corepack pnpm --dir remix run test:temporary-user` — 6/6 passed, including
  legacy temporary-record normalization and presentation-label coverage.
- `corepack pnpm --dir remix run test:unit` and
  `corepack pnpm --dir remix run typecheck:ratchet` — passed.
- Targeted Remix ESLint — 0 errors and one pre-existing Search hook dependency
  warning; the complete Vercel production build and output verification passed.
- Local desktop 1280×800 and mobile 390×844 browser QA verified the `Login`
  navigation, Anonymous profile, account switcher and settings rows, both
  `Login to claim` CTAs, login navigation, full-page scrolling, and zero
  horizontal overflow. No `Temporary space`, generated guest handle, or
  placeholder temporary email appeared; the console had only the existing
  React Router `HydrateFallback` development warning.

## Follow-up: populated kind-group runtime crash

- Fixed `groupThings()` using the removed `KIND_ICONS` local after the icon
  registry moved to `THING_KIND_ICONS`. Empty spaces never evaluated the
  section map, which is why the earlier clean-session QA did not expose the
  production-only crash seen in a populated space with Group by Kind active.
- Added the Things core/icon tests to the required unit suite. The regression
  fixture includes populated folder, post, and unknown-kind sections so both
  canonical icon lookup and the honest fallback execute at runtime.

### Validation

- `corepack pnpm --dir remix run test:things` — 6/6 passed, including the
  populated kind-group fixture; the complete unit suite and Vercel production
  build/output verification also passed.
- Local browser QA created one temporary folder, selected Arrange → Group by
  Kind, and verified `📁 Folders · 1` without an error boundary or app-console
  error at 1280×800 and 390×844. Both layouts had zero horizontal overflow,
  the mobile page reached its true bottom, and the QA folder was deleted after
  the check. The only console warning was the existing `HydrateFallback` note.
- The typecheck ratchet remains warning-only at 151 diagnostics versus its
  stale 143 baseline; none of the diagnostics are in Things core or its test.

## Follow-up: persistent browse toolbar during selection

- Selecting a Thing now adds the contextual Move / Share / Copy / Cut / Delete /
  Clear bar beneath the browse controls instead of replacing them.
- View, Show, Arrange, and Kind remain usable while a selection is active, so a
  user can change view or grouping without first clearing the selected Things.
- The permanent browse row and conditional action row both retain responsive
  wrapping on narrow screens.

### Validation

- Targeted Remix ESLint passed with 0 errors and the same 7 existing
  `ThingsPage.tsx` warnings; `corepack pnpm --dir remix run build:client`
  passed.
- The non-blocking typecheck ratchet still reports the existing 152 diagnostics
  against its stale 143 baseline; none are in `ThingsPage.tsx`.
- Local in-app browser QA at 1280×800 and 390×844 verified all View / Show /
  Arrange / Kind controls and all six selection actions remain visible together,
  changing Columns to List preserves the selection, Group opens while selected,
  Escape/Clear removes the contextual row, and both sizes scroll top-to-bottom
  without overlap or horizontal overflow. The console contained only the
  existing React Router `HydrateFallback` development warning. The temporary QA
  folder was deleted after verification.

## Follow-up: stale preview interaction recovery and PR consolidation

- The apparently inert mobile UI was an older Vercel branch-alias document:
  the captured error build loaded `index-CsNTJUhp.js`, while PR #154's current
  deployment loads `index-BzJD4WWi.js` and contains the populated-kind fix.
- Vercel preview tabs now compare their loaded hashed entry asset with the live
  alias HTML on first load, foreground return, and focus. If the alias moved,
  the stale tab reloads outside React, so the guard still runs after a route
  render failure. The check is preview-only and fails open when offline.
- A repository-wide open-PR/file-path audit found exactly one open PR touching
  the `/things` route, Things UI, or temporary Things-session support: this PR.
  Older `/things` work is already merged, and unrelated generic Things API PRs
  were deliberately left open rather than closed by a title keyword match.

### Validation

- `corepack pnpm --dir remix run test:preview-build` covers host scoping, entry
  extraction, and exact stale/current decisions.
- Current Vercel preview interaction smoke at mobile width opened Feed Filters,
  opened/closed the composer, focused and typed in the global search input,
  opened Things New, and changed Grid to List. Hit testing landed on the real
  controls and app-origin logs contained no interaction exception.

## Follow-up: Safari page-cache and pre-React recovery hardening

- The first recovery ran from `entry.client.tsx`, but ES module dependencies
  evaluate before an entry module's body. A startup/import failure could
  therefore prevent the recovery installer from running at all.
- Preview recovery now has an independent inline Vite bootstrap ordered before
  the main app. It forces a cache-busted navigation whenever Safari restores
  the page from its back/forward cache and performs one session-guarded retry
  for an asset runtime error, without creating a permanent reload loop.
- Generated Vercel root, direct-index, and SPA-fallback routes stamp the HTML
  shell `private, no-store, max-age=0, must-revalidate` plus legacy no-cache
  headers. Filesystem assets remain outside those HTML routes.

## Follow-up: persisted Thingtime function recovery

- Lopu-account mobile reproduction exposed `Function statements require a
  function name` during Thingtime hydration before the Feed composer opened.
  The stored function reviver evaluated anonymous function source as a
  statement, attempted scoped revival before Flatted had populated the scope,
  and saved its own no-op fallback back into browser state.
- Function revival now runs after the complete circular graph is restored,
  treats function source as an expression, reconstructs validated lexical
  scope, supports object-method syntax, and removes the legacy poisoned no-op
  so canonical defaults refill the missing property.

### Validation

- `corepack pnpm --dir remix run test:autosave` covers anonymous, named, arrow,
  object-method, scoped, circular, invalid, and legacy-fallback state.
- Targeted provider lint and the production client build pass. Mobile Feed QA
  opens the composer, focuses and edits Editor.js, switches to Photos, closes
  the composer, and verifies adjacent Feed controls remain interactive without
  the persisted-function exception.

## Follow-up: atomic first-load Feed input recovery

- The legacy fallback was removed in memory, but the clean value waited for the
  provider's ordinary post-render autosave. The same first render could still
  mount against the transition state, while the next tab was clean — matching
  the retained Lopu-session reproduction.
- Hydration now records whether function repair occurred and commits the merged,
  repaired snapshot before it marks the provider ready. The persistence codec
  also omits only the root runtime `set` / `get` closures so future autosaves do
  not recreate executable browser-state debris; nested user keys are unchanged.

### Validation

- `corepack pnpm --dir remix run test:autosave` covers one-pass cleanup,
  root-only runtime-method omission, nested `set` / `get` preservation, circular
  aliases, and a clean second parse.
- Targeted provider lint and the production client build pass. Browser/device
  QA covers a fresh real pointer into the collapsed composer, Editor.js focus
  and typing, global search, Latest, Filters, Photos, close/reopen, and full-page
  scrolling on desktop/mobile Chromium plus an iPhone WebKit simulator.

## Follow-up: Mobile Safari compatibility-click recovery

- A native XCUITest tap reached the exact collapsed composer button with an
  unprevented `pointerdown` / `touchstart` / `pointerup` / `touchend`, but
  Safari emitted no compatibility click. The remaining document `touchend`
  listener came from Commander's click-away wrapper and wrote global Thingtime
  state even when Commander was closed, replacing the touched React tree before
  Safari could finish the gesture.
- Commander now owns a small click-away listener that waits for `click` or
  keyboard `focusin`, ignores connected targets inside its host, and performs
  no state write unless Commander is actually active. Editor.js receives a
  touch-only synchronous focus fallback because its toolbar work during
  `touchstart` can independently suppress native contenteditable focus in
  Mobile Safari.

### Validation

- Focused Node regression tests cover the absence of a Commander `touchend`
  listener, outside-target classification, and touch-only Editor.js focus
  targeting; targeted ESLint passes with only Commander's six pre-existing
  hook-dependency warnings.
- A real Mobile Safari XCUITest on an iPhone 16 Pro simulator performs a fresh
  retained-Lopu Feed navigation, opens the collapsed composer on its first
  physical tap, opens the software keyboard from Editor.js, types and verifies
  text, opens Photos, then focuses, types, and verifies the native Tags input.